Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

External Links | Optimize behavior #2693

Merged
merged 2 commits into from
Sep 4, 2022
Merged

External Links | Optimize behavior #2693

merged 2 commits into from
Sep 4, 2022

Conversation

Fvbor
Copy link
Contributor

@Fvbor Fvbor commented Aug 17, 2022

  • Changed one link to open in a new Tab
  • Prevent tabnabbing on three links

@Fvbor
Open Externallink in new Tab
0d990e1 
The link to the backup documentation was opened in the active tab.
With this change it will open in a new tab and prevent tabnabbing
@Fvbor
Update two external Links to prevent tabnabbing
d9c0eb3 
Added noopener to prevent tabnabbing
@BlackDex
Copy link
Collaborator

While _blank targets by default have noopener already in most modern browsers i think adding it doesn't do any harm either.
Also see: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/a#browser_compatibility

@BlackDex
Copy link
Collaborator

Also, nice catch for the backup link. That should have been a _blank also from the start :).

@Fvbor
Copy link
Contributor Author

Fvbor commented Aug 17, 2022

While _blank targets by default have noopener already in most modern browsers i think adding it doesn't do any harm either. Also see: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/a#browser_compatibility

Ah! Good to know. Didn`t saw this in my source.

Also, nice catch for the backup link. That should have been a _blank also from the start :).

I clicked on the link and my tab was gone... :D

@dani-garcia dani-garcia merged commit 3c876dc into dani-garcia:main Sep 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GeekCornerGH GeekCornerGH GeekCornerGH approved these changes

@BlackDex BlackDex BlackDex approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Fvbor @BlackDex @GeekCornerGH @dani-garcia